Fixed PMD P2 issues and UseUtilityClass, EmptyCatchBlock #4465

shai-almog · 2026-01-27T02:36:10Z

No description provided.

shai-almog · 2026-01-27T02:50:06Z

Compared 30 screenshots: 30 matched.

Native Android coverage

📊 Line coverage: 24.73% (2650/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.38% (12321/50528), branch 15.28% (714/4672), complexity 17.47% (741/4241), method 32.91% (599/1820), class 34.65% (105/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

📊 Line coverage: 24.73% (2650/10717 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
- Other counters: instruction 24.38% (12321/50528), branch 15.28% (714/4672), complexity 17.47% (741/4241), method 32.91% (599/1820), class 34.65% (105/303)
- Lowest covered classes
  - com.codename1.impl.android.com.codename1.impl.android.AndroidContactsManager – 0.00% (0/400 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$Video – 0.00% (0/168 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.IntentIntegrator – 0.00% (0/139 lines covered)
  - com.codename1.impl.android.util.com.codename1.impl.android.util.Base64 – 0.00% (0/117 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidImplementation$SocketImpl – 0.00% (0/77 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidTextureView – 0.00% (0/76 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.AndroidSurfaceView – 0.00% (0/73 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.LocalNotificationPublisher – 0.00% (0/65 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.FridaDetectionUtil – 0.00% (0/64 lines covered)
  - com.codename1.impl.android.com.codename1.impl.android.PushNotificationService – 0.00% (0/59 lines covered)

github-actions · 2026-01-27T03:00:41Z

✅ Continuous Quality Report

Test & Coverage

✅ Tests: 2283 total, 0 failed, 0 skipped
📊 Line coverage: 52.78% [HTML preview] [Download]
- Lowest covered classes
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
  - com.codename1.ui.Display$EdtException – 0.00%
  - com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
  - com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
  - com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
  - com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
  - com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

✅ SpotBugs: 0 findings (no issues) [Report archive]
❌ PMD: 159 findings (P3: 148, P4: 11) [HTML preview] [Download]
- Top findings
  - P3: CodenameOne/src/com/codename1/ads/AdsService.java:62 – 'catch' branch identical to 'InstantiationException' branch (rule: IdenticalCatchBranches)
  - P3: CodenameOne/src/com/codename1/ads/InnerActive.java:43 – This final field could be made static (rule: FinalFieldCouldBeStatic)
  - P3: CodenameOne/src/com/codename1/ads/InnerActive.java:54 – Avoid unnecessary constructors - the compiler will generate these for you (rule: UnnecessaryConstructor)
  - P3: CodenameOne/src/com/codename1/ads/InnerActive.java:186 – Avoid unnecessary if..then..else statements when returning booleans (rule: SimplifyBooleanReturns)
  - P3: CodenameOne/src/com/codename1/annotations/Async.java:19 – Class cannot be instantiated and does not provide any static methods or fields (rule: MissingStaticMethodInNonInstantiatableClass)
  - …and 154 more
❌ Checkstyle: 221059 findings (Warning: 221059) [HTML preview] [Download]
- Top findings
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
  - …and 221054 more

Generated automatically by the PR CI workflow.

shai-almog · 2026-01-27T03:24:23Z

iOS screenshot updates

Compared 30 screenshots: 23 matched, 6 updated, 1 missing reference.

BrowserComponent — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as BrowserComponent.png in workflow artifacts.
graphics-draw-arc — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 20; JPEG preview quality 20; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-arc.png in workflow artifacts.
graphics-draw-gradient — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-gradient.png in workflow artifacts.
graphics-draw-round-rect — missing reference. Reference screenshot missing at /Users/runner/work/CodenameOne/CodenameOne/scripts/ios/screenshots/graphics-draw-round-rect.png.

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 844x1835.
Full-resolution PNG saved as graphics-draw-round-rect.png in workflow artifacts.
graphics-draw-string — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 422x918.
Full-resolution PNG saved as graphics-draw-string.png in workflow artifacts.
graphics-draw-string-decorated — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: JPEG preview quality 10; JPEG preview quality 10; downscaled to 603x1311.
Full-resolution PNG saved as graphics-draw-string-decorated.png in workflow artifacts.
kotlin — updated screenshot. Screenshot differs (1206x2622 px, bit depth 8).

Preview info: Preview provided by instrumentation.
Full-resolution PNG saved as kotlin.png in workflow artifacts.

Benchmark Results

VM Translation Time: 352 seconds
Compilation Time: 225 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	32154 ms
Extract Extensions	15 ms
Google Services Setup	1 ms
Scan Classes	411 ms
Extract Libs	845 ms
Inject Build Hints	32 ms
Generate Unit Tests	3 ms
Generate Stubs	998 ms
Compile Stubs	2038 ms
Generate Icons	962 ms
Prepare ParparVM	203 ms
ParparVM Execution	190506 ms
Post-VM Setup	142 ms
CocoaPods	6294 ms
Finalize	52 ms
Total Time	234657 msMaven Overhead : 118000 ms
CocoaPods Install (Script)	2000 ms
Simulator Boot	75000 ms
Simulator Boot (Run)	5000 ms
App Install	18000 ms
App Launch	12000 ms
Test Execution	164000 ms

Fixed PMD P2 issues and UseUtilityClass, EmptyCatchBlock

ebafa5b

shai-almog force-pushed the pmd-fixed-p2-issues-UseUtilityClass-EmptyCatchBlock branch from f172f9a to ebafa5b Compare January 27, 2026 02:51

shai-almog merged commit 49c8c86 into master Jan 27, 2026
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed PMD P2 issues and UseUtilityClass, EmptyCatchBlock #4465

Fixed PMD P2 issues and UseUtilityClass, EmptyCatchBlock #4465

shai-almog commented Jan 27, 2026

Uh oh!

shai-almog commented Jan 27, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

shai-almog commented Jan 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fixed PMD P2 issues and UseUtilityClass, EmptyCatchBlock #4465

Fixed PMD P2 issues and UseUtilityClass, EmptyCatchBlock #4465

Conversation

shai-almog commented Jan 27, 2026

Uh oh!

shai-almog commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Android coverage

Native Android coverage

Uh oh!

github-actions bot commented Jan 27, 2026

✅ Continuous Quality Report

Test & Coverage

Static Analysis

Uh oh!

shai-almog commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS screenshot updates

Benchmark Results

Detailed Performance Metrics

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shai-almog commented Jan 27, 2026 •

edited

Loading

shai-almog commented Jan 27, 2026 •

edited

Loading